chapter_name may not be a character vector of length 1

atyre2 · Apr 6, 2017 · f23b2d4 · f23b2d4
1 parent 9ea8ffa
commit f23b2d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -20,6 +20,8 @@
 
 - Some text references do not work for HTML and Word output (thanks, @ugroempi, #363).
 
+- The option `chapter_name` in `_bookdown.yml` does not work when it is specified as a function (thanks, @tzerk, 0c05c3828be).
+
 ## MINOR CHANGES
 
 - The `daemon` argument was removed from `serve_book()`, but you can still pass it to `servr::httw()` via the `...` argument.

diff --git a/R/html.R b/R/html.R
@@ -653,7 +653,7 @@ add_toc_ids = function(toc) {
 add_chapter_prefix = function(content) {
   config = load_config()
   chapter_name = config[['chapter_name']] %n% ui_language('chapter_name')
-  if (is.null(chapter_name) || chapter_name == '') return(content)
+  if (is.null(chapter_name) || identical(chapter_name, '')) return(content)
   chapter_fun = if (is.character(chapter_name)) {
     function(i) switch(
       length(chapter_name), paste0(chapter_name, i),