Allow Firehose authentication using sts credentials (kolide#2034)

austburn · Apr 24, 2019 · ad12ee4 · ad12ee4
1 parent 75868a7
commit ad12ee4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/server/logging/firehose.go b/server/logging/firehose.go
@@ -34,10 +34,17 @@ type firehoseLogWriter struct {
 }
 
 func NewFirehoseLogWriter(region, id, secret, stream string, logger log.Logger) (*firehoseLogWriter, error) {
-	sess, err := session.NewSession(&aws.Config{
-		Credentials: credentials.NewStaticCredentials(id, secret, ""),
-		Region:      &region,
-	})
+	conf := &aws.Config{
+		Region: &region,
+	}
+
+	// Only provide static credentials if we have them
+	// otherwise use the default credentials provider chain
+	if id != "" && secret != "" {
+		conf.Credentials = credentials.NewStaticCredentials(id, secret, "")
+	}
+
+	sess, err := session.NewSession(conf)
 	if err != nil {
 		return nil, errors.Wrap(err, "create Firehose client")
 	}