wip

austintoddj · Nov 10, 2020 · 3e374a8 · 3e374a8
1 parent dd6357a
commit 3e374a8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -13,7 +13,7 @@ jobs:
 
     runs-on: ubuntu-latest
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         php: [7.3, 7.4, 8.0]
         laravel: [^6.0, ^7.0, ^8.0]

diff --git a/tests/Http/Controllers/Auth/AuthenticatedSessionControllerTest.php b/tests/Http/Controllers/Auth/AuthenticatedSessionControllerTest.php
@@ -30,7 +30,7 @@ public function testLoginRequestWillValidateAnInvalidEmail(): void
         $response = $this->post('/canvas/login', [
             'email' => 'not-an-email',
             'password' => 'password',
-        ]);
+        ])->assertSessionHas('errors');
 
         $this->assertInstanceOf(ValidationException::class, $response->exception);
     }
@@ -40,7 +40,7 @@ public function testLoginRequestWillValidateAnEmailNotInTheDatabase(): void
         $response = $this->post('/canvas/login', [
             'email' => '[email protected]',
             'password' => 'password',
-        ]);
+        ])->assertSessionHas('errors');
 
         $this->assertInstanceOf(ValidationException::class, $response->exception);
     }