Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with 'rows' references #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

d60402
Copy link

@d60402 d60402 commented Jun 25, 2019

- Remove unused `rows` vars where they are not used
- Rename `rows` to `rowCount` since this is matches [the callback signature names](https://tediousjs.github.io/tedious/api-request.html#function_newRequest)
- Add `rowCollectionOnRequestCompletion: true` to new Connection() options since [without this, rows is not returned](https://tediousjs.github.io/tedious/api-request.html#function_newRequest)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant