Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Succint Header Change #39

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Succint Header Change #39

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b260af
added header changes
kroos47 Oct 3, 2023
0302b26
minor fixes
kroos47 Oct 3, 2023
5448587
header change
kroos47 Oct 31, 2023
4cc4721
lint
kroos47 Oct 31, 2023
7b636ac
rm vtest
kroos47 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/apps-config/src/api/spec/dataavail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ const definitions: OverrideBundleDefinition = {
KateCommitment: {
rows: 'Compact<u16>',
cols: 'Compact<u16>',
dataRoot: 'H256',
commitment: 'Vec<u8>'
commitment: 'Vec<u8>',
dataRoot: 'H256'
},
V1HeaderExtension: {
commitment: 'KateCommitment',
appLookup: 'DataLookup'
appLookup: 'DataLookup',
commitment: 'KateCommitment'
},
VTHeaderExtension: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be changed too ? Just for the sake of completion ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Kate Commitment and Header Extension needed change? @kroos47

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its being done in another place where types are overriden

newField: 'Vec<u8>',
Expand Down
4 changes: 2 additions & 2 deletions packages/apps-config/src/api/typesBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49674,12 +49674,12 @@
"KateCommitment": {
"rows": "Compact<u16>",
"cols": "Compact<u16>",
"commitment": "Vec<u8>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this missing, I don't see that order was changed?

"dataRoot": "H256",

Check failure on line 49678 in packages/apps-config/src/api/typesBundle.ts

View workflow job for this annotation

GitHub Actions / pr (lint) 

Unexpected trailing comma
"commitment": "Vec<u8>"
},
"V1HeaderExtension": {
"appLookup": "DataLookup",
"commitment": "KateCommitment",

Check failure on line 49682 in packages/apps-config/src/api/typesBundle.ts

View workflow job for this annotation

GitHub Actions / pr (lint) 

Unexpected trailing comma
"appLookup": "DataLookup"
},
"VTHeaderExtension": {
"newField": "Vec<u8>",
Expand Down
Loading