Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed previous iterative rounding codes #75

Closed
wants to merge 1 commit into from
Closed

removed previous iterative rounding codes #75

wants to merge 1 commit into from

Conversation

komietty
Copy link

Removing the previous iterative rounding code in the integrate.h which is duplicated with iterative_rounding.h.

@komietty komietty closed this May 30, 2024
@komietty
Copy link
Author

Sorry, this includes some setting file updates. I recreated another PR.

@avaxman
Copy link
Owner

avaxman commented May 30, 2024

Thank you for this. I have to think about it, but in fact this gets overridden by the upcoming (hopefully in two weeks) version of Directional where I totally removed the "optimization" and only left this code... in addition, the part that reduces the rank of C is vital nonetheless, and cannot be removed.

@avaxman
Copy link
Owner

avaxman commented May 30, 2024

You can check it out in the "remove-dependencies" branch, which is working up to integration including---currently working on the 505 meshing (which requires heavy code writing to supplement CGAL).

@komietty
Copy link
Author

komietty commented May 30, 2024

@avaxman Thank you for the reply! I'm glad to hear that this project will be upgraded. I checked the libigl-free branch and the codes in integrate.h which seems great. As for the rank reduction of the constraint matrix, I thought the same thing was done when creating CSmall matrix inside SIInitialSolutionTraits::init() (I have checked that the same matrix was generated), but you are right, it is better to have pre rank reduction beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants