Skip to content

Commit

Permalink
docs(fish): lower version requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
lewis-yeung authored and JanDeDobbeleer committed Jul 11, 2024
1 parent 66f1347 commit ad34a6e
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 8 deletions.
3 changes: 1 addition & 2 deletions src/prompt/tooltip.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,8 @@ func (e *Engine) Tooltip(tip string) string {
switch e.Env.Shell() {
case shell.PWSH, shell.PWSH5:
e.rprompt = text
e.rpromptLength = length
e.currentLineLength = e.Env.Flags().Column
space, ok := e.canWriteRightBlock(true)
space, ok := e.canWriteRightBlock(length, true)
if !ok {
return ""
}
Expand Down
4 changes: 0 additions & 4 deletions website/docs/faq.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,6 @@ setopt appendhistory

This is most likely caused by two Oh My Posh init lines in your `.zshrc`, remove one of them. See [here][zsh-init].

### Fish: $(...) is not supported

You should update fish to v3.4.0 or higher. Fish supports `$(...)` and `"$(...)"` since v3.4.0, as described in its [changelog][fish-changelog].

### Fish: Display current bind (Vim) mode

Use the `set_poshcontext` function to export the current mode. Note that scope shadowing must be disabled in order to
Expand Down
2 changes: 1 addition & 1 deletion website/docs/installation/customize.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ exec elvish
<TabItem value="fish">

:::caution
Oh My Posh requires fish v3.4.0 or higher.
It is recommended to use the latest version of Fish. Versions below 3.1.2 have issues displaying the prompt.
:::

Adjust the Oh My Posh init line in `~/.config/fish/config.fish` by adding the `--config` flag with
Expand Down
2 changes: 1 addition & 1 deletion website/docs/installation/prompt.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ exec elvish
<TabItem value="fish">

:::caution
Oh My Posh requires fish v3.4.0 or higher.
It is recommended to use the latest version of Fish. Versions below 3.1.2 have issues displaying the prompt.
:::

Initialize Oh My Posh in `~/.config/fish/config.fish`:
Expand Down

0 comments on commit ad34a6e

Please sign in to comment.