-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing CDK Pipelines for resource orchestration #293
base: main
Are you sure you want to change the base?
Conversation
Changed base images to Public ECR
- "true" | ||
- "false" | ||
Type: String | ||
BootstrapVariant: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Parameter BootstrapVariant not used.
- HasCustomFileAssetsBucketName | ||
- Fn::Sub: ${FileAssetsBucketName} | ||
- Fn::Sub: cdk-${Qualifier}-assets-${AWS::AccountId}-${AWS::Region} | ||
AccessControl: Private |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Consider using AWS::S3::BucketPolicy instead of AccessControl
Fn::Sub: alias/cdk-${Qualifier}-assets-key | ||
TargetKeyId: | ||
Ref: FileAssetsBucketEncryptionKey | ||
StagingBucket: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Ensure that S3 buckets have cross-region replication enabled. By enabling cross-region replication for your S3 buckets, you create redundant copies of your data in different AWS regions. This helps improve data durability and availability, as well as provides protection against regional outages. It also allows you to comply with data residency requirements by replicating data to specific regions.
- "true" | ||
- Ref: PublicAccessBlockConfiguration | ||
Resources: | ||
FileAssetsBucketEncryptionKey: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Ensure KMS key policy does not contain wildcard (*) principal
Fn::Sub: alias/cdk-${Qualifier}-assets-key | ||
TargetKeyId: | ||
Ref: FileAssetsBucketEncryptionKey | ||
StagingBucket: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Ensure S3 bucket has ignore public ACLs enabled
Fn::Sub: alias/cdk-${Qualifier}-assets-key | ||
TargetKeyId: | ||
Ref: FileAssetsBucketEncryptionKey | ||
StagingBucket: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Ensure S3 bucket has 'restrict_public_bucket' enabled
Fix typo in X-Ray Group
Issue #, if available:
N/A
Description of changes:
Implement CDK Pipeline approach to enable CDK modules customization, improve support.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.