fix/ecdsa verification to use raw signature format per jwa spec #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Fixed ES256, ES384 and ES512 implementation: these should use raw signature format (r || s, as per JWA spec) but Node.js uses ASN.1 DER format by default. This can be switched to raw format by providing
dsaEncoding: "ieee-p1363"
which I added (thanks for the tip @NicolasViaud).Also discovered that the browser implementation did not support the ECDSA formats at all yet, so added that.
And as icing on the cake, I finally fixed the browser test scrips so it doesn't orphan Vite processes anymore as it sometimes did! 🎉
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.