Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin supported CNI versions #99

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

austinvazquez
Copy link
Contributor

Issue #, if available:
#98

Before this change, plugin version 1.0.0 was not being reported as supported after version 1.1.0 became the current version.

Description of changes:
This change reworks the supported versions logic to use CNI version.All variable instead of version.CurrentVersion function whose value changes across plugin versions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Before this change, plugin version 1.0.0 was not being reported as supported
after version 1.1.0 became the current version.

Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez austinvazquez requested a review from a team as a code owner November 29, 2024 20:03
Copy link
Contributor

@sondavidb sondavidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad there's an easy way to get all the versions. Confirmed on my end that this at least partially mitigates the original issue. Thanks!

@sondavidb sondavidb merged commit f2644ce into awslabs:master Jan 10, 2025
4 checks passed
@austinvazquez austinvazquez deleted the fix-version-checks branch January 10, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants