Skip to content

Commit

Permalink
MFC r367291:
Browse files Browse the repository at this point in the history
rc.d/zfs: Add shutdown to KEYWORDS

The problem is that without walling /etc/rc.d/zfs on shutdown, resources
associated with ZFS mounts are not freed and the jails will remain in dying
state. In addition, the dataset is now in a dangling state, as the jail it
is attached to is dying.

A known workaround for jails was to add the following lines
to /etc/jail.conf, to make sure that "service zfs stop" is run
when the jail is stopped:

    exec.stop = "/bin/sh /etc/rc.shutdown";
    exec.stop += "/usr/sbin/service zfs stop || /usr/bin/true";

While the workaround seems to be okay-ish for the jail situation, it is
still unclean. However, for physical hosts this may wreak havoc with the
pool if shared spares are used, as "zfs unshare" is never invoked on
shutdown.

PR:		147444
Submitted by:	Markus Stoff <markus__stoffdv_at>
Reported by:	Mykah <mburkhardt__exavault_com>
Reviewed by:	cy
Approved by:	cy (src)
Relnotes:	yes
  • Loading branch information
0mp committed Nov 10, 2020
1 parent 1b68f5b commit cd13371
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions libexec/rc/rc.d/zfs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
# PROVIDE: zfs
# REQUIRE: zfsbe
# BEFORE: FILESYSTEMS var
# KEYWORD: shutdown

. /etc/rc.subr

Expand Down

0 comments on commit cd13371

Please sign in to comment.