Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/law stone minor refactoring #686

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Dec 23, 2024

Just ensure safer conversion of object_ref URI into Prolog atom when querying for source files in the law-stone smart contract.

AFAIK, the old implementation didn’t have any security issues by design, but this update uses a safer conversion function that handles escaping properly. Just keeping things a bit more robust, you know, for good measure.

@ccamel ccamel self-assigned this Dec 23, 2024
@bot-anik
Copy link
Member

bot-anik commented Dec 23, 2024

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/axone_objectarium.wasm 459.15 KB (0%)
target/wasm32-unknown-unknown/release/axone_law_stone.wasm 595.11 KB (+0.17% 🔺)
target/wasm32-unknown-unknown/release/axone_cognitarium.wasm 883.1 KB (0%)
target/wasm32-unknown-unknown/release/axone_dataverse.wasm 698.22 KB (0%)

@ccamel ccamel force-pushed the refactor/law-stone-minor-refactoring branch from db6c752 to 84df057 Compare December 23, 2024 18:12
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/axone-logic-bindings/src/atom.rs 96.55% 1 Missing ⚠️
Files with missing lines Coverage Δ
contracts/axone-law-stone/src/contract.rs 96.09% <100.00%> (-0.01%) ⬇️
packages/axone-logic-bindings/src/atom.rs 96.55% <96.55%> (ø)

... and 7 files with indirect coverage changes

@ccamel ccamel merged commit 657164b into main Dec 23, 2024
17 checks passed
@ccamel ccamel deleted the refactor/law-stone-minor-refactoring branch December 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants