fix: state update error

ayancikli · Jul 8, 2020 · b61854e · b61854e
1 parent 3de74dc
commit b61854e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/src/components/player/index.js b/src/components/player/index.js
@@ -1,6 +1,6 @@
 import React, { useState, useContext, createContext } from 'react';
 import ReactDOM from 'react-dom';
-import { Container, Button, Overlay, Inner } from './styles/player';
+import { Container, Button, Overlay, Inner, Close } from './styles/player';
 
 export const PlayerContext = createContext();
 
@@ -24,6 +24,7 @@ Player.Video = function PlayerVideo({ ...restProps }) {
             <video id="netflix-player" controls>
               <source src="/videos/bunny.mp4" type="video/mp4" />
             </video>
+            <Close />
           </Inner>
         </Overlay>,
         document.body

diff --git a/src/constants/routes.js b/src/constants/routes.js
@@ -2,4 +2,3 @@ export const HOME = '/';
 export const BROWSE = '/browse';
 export const SIGN_UP = '/signup';
 export const SIGN_IN = '/signin';
-export const PASSWORD_FORGET = '/password-reset';
diff --git a/src/pages/signin.js b/src/pages/signin.js
@@ -23,12 +23,13 @@ export default function Signin() {
       .auth()
       .signInWithEmailAndPassword(emailAddress, password)
       .then(() => {
-        setEmailAddress('');
-        setPassword('');
-        setError('');
         history.push(ROUTES.BROWSE);
       })
-      .catch((error) => setError(error.message));
+      .catch((error) => {
+        setEmailAddress('');
+        setPassword('');
+        setError(error.message);
+      });
   };
 
   return (

diff --git a/src/pages/signup.js b/src/pages/signup.js
@@ -30,13 +30,14 @@ export default function Signup() {
             photoURL: Math.floor(Math.random() * 5) + 1,
           })
           .then(() => {
-            setEmailAddress('');
-            setPassword('');
-            setError('');
             history.push(ROUTES.BROWSE);
           })
       )
-      .catch((error) => setError(error.message));
+      .catch((error) => {
+        setEmailAddress('');
+        setPassword('');
+        setError(error.message);
+      });
   };
 
   return (