[BUGFIX] parsing of urls from DB #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimfritz
commented
Nov 19, 2019
| @@ -174,8 +174,8 @@ protected function groupUrlsByAllowedZones(array $urls): array | |||
| $availableZones = $this->getZones(); | |||
| foreach ($availableZones as $domain => $zoneId) { | |||
| $groupedUrls[$zoneId] = array_filter($urls, function($url) use ($domain) { | |||
| $urlParts = []; | |||
| parse_str($url, $urlParts); | |||
| $url = unserialize($url); | |||
There was a problem hiding this comment.
$urls are saved serialized in Database, can we save the as string? (because $url is "untrusted user input")
There was a problem hiding this comment.
We should implement "TransientBackendInterface" instead.
| @@ -174,8 +174,8 @@ protected function groupUrlsByAllowedZones(array $urls): array | |||
| $availableZones = $this->getZones(); | |||
| foreach ($availableZones as $domain => $zoneId) { | |||
| $groupedUrls[$zoneId] = array_filter($urls, function($url) use ($domain) { | |||
| $urlParts = []; | |||
| parse_str($url, $urlParts); | |||
There was a problem hiding this comment.
hm, is this a typo?
achimfritz
force-pushed
the
bugfix/url-parsing
branch
from
913b18b to
d4479cd
Compare
achimfritz
changed the title
bmack
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.