Fix error saving actor state for readonly changes (dapr#233)

Signed-off-by: Tianpeng Wang <[email protected]>
back-in-sunset · Jan 11, 2022 · d3c3384 · d3c3384
1 parent 40d8a4e
commit d3c3384
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/actor/state/state_async_provider.go b/actor/state/state_async_provider.go
@@ -88,6 +88,11 @@ func (d *DaprStateAsyncProvider) Apply(actorType, actorID string, changes []*Act
 			Value:         value,
 		})
 	}
+
+	if len(operations) == 0 {
+		return nil
+	}
+
 	return d.daprClient.SaveStateTransactionally(context.Background(), actorType, actorID, operations)
 }
 

diff --git a/actor/state/state_async_provider_test.go b/actor/state/state_async_provider_test.go
@@ -37,6 +37,35 @@ func TestDaprStateAsyncProvider_Apply(t *testing.T) {
 		args    args
 		wantErr bool
 	}{
+		{
+			name: "empty changes",
+			args: args{
+				actorType: "testActor",
+				actorID:   "test-0",
+				changes:   nil,
+			},
+			wantErr: false,
+		},
+		{
+			name: "only readonly state changes",
+			args: args{
+				actorType: "testActor",
+				actorID:   "test-0",
+				changes: []*ActorStateChange{
+					{
+						stateName:  "stateName1",
+						value:      "Any",
+						changeKind: None,
+					},
+					{
+						stateName:  "stateName2",
+						value:      "Any",
+						changeKind: None,
+					},
+				},
+			},
+			wantErr: false,
+		},
 		// TODO: Add test cases.
 	}
 	for _, tt := range tests {