Skip to content

Commit

Permalink
Add upper limit on grpcio-tools version (facebookresearch#671)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookresearch#671

CircleCI tests started failing. Example: https://app.circleci.com/pipelines/github/facebookresearch/ReAgent/2490/workflows/efbceb68-9a01-4889-8d82-3d4167af4643/jobs/24780
Root cause is a significant jump in protobuf version from 3.19.4 to 4.21.5. This was caused by an an updated dependency on protobuf in grcpio-tools.
I'm adding an upper limit on grcpio-tools version to prevent this error

Reviewed By: BerenLuthien, czxttkl

Differential Revision: D38870120

fbshipit-source-id: 10d2e619aa10c2b03272b8305681792feefd06f4
  • Loading branch information
alexnikulkov authored and facebook-github-bot committed Aug 19, 2022
1 parent 9085aae commit ebbfb25
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ license = BSD 3-Clause License
packages = find:
python_requires = >=3.8
install_requires =
grpcio-tools>=1.44.0
# v1.48.0 and above upgraded the protobuf dependency, which lead to an error:
# https://stackoverflow.com/questions/72441758/typeerror-descriptors-cannot-not-be-created-directly
grpcio-tools>=1.44.0,<1.48.0
click>=7.0
# ~=1.2.0 for compatibility with gym
# issue: https://github.com/openai/spinningup/issues/178
Expand Down

0 comments on commit ebbfb25

Please sign in to comment.