This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Update kuttl e2e to work with OCP on AWS #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc: @sallyom |
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
========================================
- Coverage 76.3% 76.1% -0.2%
========================================
Files 9 9
Lines 1956 1956
========================================
- Hits 1493 1490 -3
- Misses 359 360 +1
- Partials 104 106 +2
|
Signed-off-by: John Strunk <[email protected]>
The e2e tests now require a topology key to be present on nodes so that the tests work w/ multi-zone cluters. This adds a topology label to the kind node when it is created so that there is something to match against. Signed-off-by: John Strunk <[email protected]>
Signed-off-by: John Strunk <[email protected]>
Signed-off-by: John Strunk <[email protected]>
Signed-off-by: John Strunk <[email protected]>
Signed-off-by: John Strunk <[email protected]>
For testing the e2e on OCP/AWS, I have:
--- PASS: kuttl (349.75s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/simple-rsync (118.46s)
--- PASS: kuttl/harness/restic-with-manual-trigger (197.72s)
--- PASS: kuttl/harness/simple-rclone (144.57s)
--- PASS: kuttl/harness/restic-without-trigger (143.22s)
PASS |
JohnStrunk
changed the title
WIP: Update kuttl e2e to work with OCP on AWS
Update kuttl e2e to work with OCP on AWS
Jul 23, 2021
/assign sallyom |
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Adds updates to the kuttl-based e2e suite so that it works in OpenShift on AWS
Overview of updates:
CopyMethod
must beSnapshot
sync
before the snapshot happens or there's no guarantee the latest data will make it into the EBS snapshot.sync
before exiting to ensure snapshots have all the dataIs there anything that requires special attention?
Related issues: