Skip to content

Commit

Permalink
remove REPORT_IDS constant
Browse files Browse the repository at this point in the history
  • Loading branch information
Julesssss committed Oct 12, 2020
1 parent 5a97525 commit a7572d6
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/**
* Rename this file to `.env` and put your local config in here
*/
REPORT_IDS=1,2,3
EXPENSIFY_API_ROOT=https://www.expensify.com.dev/api?
EXPENSIFY_PARTNER_NAME=android
EXPENSIFY_PARTNER_PASSWORD=c3a9ac418ea3f152aae2
Expand Down
1 change: 0 additions & 1 deletion .env.production
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
REPORT_IDS=
EXPENSIFY_API_ROOT=https://www.expensify.com/api?
EXPENSIFY_PARTNER_NAME=chat-expensify-com
EXPENSIFY_PARTNER_PASSWORD=e21965746fd75f82bb66
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ This application is built with the following principles.
1. Install `node` & `npm`: `brew install node`
2. Install `watchman`: `brew install watchman`
3. Install dependencies: `npm install`
4. Run `cp .env.example .env` and edit `.env` to have your local config options(for example, we are curretly hardcoding the pinned chat reports IDs with the `REPORT_IDS` config option).
4. Run `cp .env.example .env` and edit `.env` to have your local config options.

You can use any IDE or code editing tool for developing on any platform. Use your favorite!

Expand Down
1 change: 0 additions & 1 deletion src/CONFIG.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export default {
APP_KEY: Config.PUSHER_APP_KEY,
CLUSTER: 'mt1',
},
REPORT_IDS: Config.REPORT_IDS,
SITE_TITLE: 'Chat',
FAVICON: {
DEFAULT: 'favicon.png',
Expand Down
3 changes: 1 addition & 2 deletions src/lib/actions/Report.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import ExpensiMark from 'js-libs/lib/ExpensiMark';
import Ion from '../Ion';
import * as API from '../API';
import IONKEYS from '../../IONKEYS';
import CONFIG from '../../CONFIG';
import * as Pusher from '../Pusher/pusher';
import promiseAllSettled from '../promiseAllSettled';
import Notification from '../Notification';
Expand Down Expand Up @@ -51,7 +50,7 @@ Ion.connect({
const reportMaxSequenceNumbers = {};

// List of reportIDs that we define in .env
const configReportIDs = CONFIG.REPORT_IDS.split(',').map(Number);
const configReportIDs = '';

/**
* Checks the report to see if there are any unread action items
Expand Down

0 comments on commit a7572d6

Please sign in to comment.