sessionctx/binloginfo: fix goroutine leak in test (pingcap#31964)

close pingcap#31963
baijianguo · Jan 26, 2022 · 76a9eea · 76a9eea
1 parent b83dc00
commit 76a9eea
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/sessionctx/binloginfo/binloginfo_test.go b/sessionctx/binloginfo/binloginfo_test.go
@@ -112,6 +112,7 @@ func createBinlogSuite(t *testing.T) (s *binlogSuite, clean func()) {
 	s.ddl.SetBinlogClient(s.client)
 
 	clean = func() {
+		clientCon.Close()
 		err = s.ddl.Stop()
 		require.NoError(t, err)
 		s.serv.Stop()

diff --git a/sessionctx/binloginfo/main_test.go b/sessionctx/binloginfo/main_test.go
@@ -24,8 +24,6 @@ import (
 func TestMain(m *testing.M) {
 	testbridge.SetupForCommonTest()
 	opts := []goleak.Option{
-		goleak.IgnoreTopFunction("google.golang.org/grpc.(*addrConn).resetTransport"),
-		goleak.IgnoreTopFunction("google.golang.org/grpc.(*ccBalancerWrapper).watcher"),
 		goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
 		goleak.IgnoreTopFunction("go.etcd.io/etcd/pkg/logutil.(*MergeLogger).outputLoop"),
 	}