Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade librespot #683

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rouk1
Copy link

@rouk1 rouk1 commented Mar 1, 2025

librespot as been updated quite a few times since 0.4.2. It seems that the new API is used and authentication has been hardened.

@GioF71 has released a docker image which builds cross platform images with github actions. This is really handy as building librespot for muliple platform is kind of long...

Hence this PR is a proposal to switch from @andrewn's image to Giovanni's one. This will make us jump to librespot 0.6.0.
So far this fixes #669 and #671 for my setup. Only a few hours of testing though but I can see in the log that 502 errors are handled without dropping audio.

 spotify  [2025-03-01T15:11:42Z INFO  librespot_playback::player] Loading <Colours Fly> with Spotify URI <spotify:track:4iwIvzR9ZENkaH32bPZuB5>
 spotify  [2025-03-01T15:11:42Z ERROR librespot_connect::spirc] ContextError: Error { kind: Unknown, error: StatusCode(502) }
 spotify  [2025-03-01T15:11:43Z INFO  librespot_playback::player] <Colours Fly> (295706 ms) loaded

Copy link
Contributor

flowzone-app bot commented Mar 1, 2025

A repository maintainer needs to approve this workflow run.

https://github.com/balena-io-experimental/balena-sound/actions/runs/13606359136

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@GioF71
Copy link

GioF71 commented Mar 1, 2025

Hello @rouk1, I have to tell you since you wrote:

which builds cross platform images with github actions

that I actually had to step away from github actions for this image because the build process fails with a segfault for the arm64 platform. AFAIK this is qemu-related but that's what I can use with the github free tier (I would be glad to be corrected here).
I did not want to drop the arm64/v8 building even if the armv7/32 should be good for 64bit OS users, so now I am building from my desktop using docker buildx with a Pi4 worker machine for the arm32/v7 and arm64/v8, and then pushing my local builds to docker hub.

@rouk1
Copy link
Author

rouk1 commented Mar 1, 2025

I actually had to step away from github actions for this image

Woo thanks for explanations : )
I misunderstood what you did. Anyway your work is really useful and this is always nice to stumble on a repo which solve tedious tasks.

@GioF71
Copy link

GioF71 commented Mar 1, 2025

I misunderstood what you did

Can't blame you for that, since the workflow is still there, and since I have been using github actions since the beginning.
I will try from time to time if the issue is solved. Thinking about this, I will try a test build as we are writing these posts.

@GioF71
Copy link

GioF71 commented Mar 1, 2025

Fun, the build with github action just went through successfully. It takes a ridiculous amount of time though.

@andrewn
Copy link
Contributor

andrewn commented Mar 2, 2025

Hence this PR is a proposal to switch from @andrewn's image to Giovanni's one. This will make us jump to librespot 0.6.0.

That sounds good, as I'm not using librespot that much anymore.

I tried to get everything building using Github Actions a while back but couldn't get all the platforms building so I abondoned it.

Let me know if you'd like me to release a new build with v0.6.0. I can do it locally fairly easily as I have everything setup still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track skipping due to upstream Spotify API issues.
3 participants