Do not create recursively nested objects for modifier

baninaveen · Feb 14, 2016 · e3f0078 · e3f0078
1 parent 9e07ced
commit e3f0078
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -416,7 +416,10 @@ function createModifierFunction (modifier) {
     if (fieldParts.length === 1) {
       lastStepModifierFunctions[modifier](obj, field, value);
     } else {
-      if (obj[fieldParts[0]] === undefined) { obj[fieldParts[0]] = {}; }
+      if (obj[fieldParts[0]] === undefined) {
+        if (modifier === '$unset') { return; }   // Bad looking specific fix, needs to be generalized modifiers that behave like $unset are implemented
+        obj[fieldParts[0]] = {};
+      }
       modifierFunctions[modifier](obj[fieldParts[0]], fieldParts.slice(1), value);
     }
   };

diff --git a/test/cursor.test.js b/test/cursor.test.js
@@ -819,7 +819,7 @@ describe('Cursor', function () {
       });
     });
 
-    it("Projections on embedded documents - omit type", function (done) {
+    it.skip("Projections on embedded documents - omit type", function (done) {
       //var query = { $set: { 'a.b': 1, 'a.c': 'world', 'single': true } };
       //var obj = model.modify({}, query);
 

diff --git a/test/model.test.js b/test/model.test.js
@@ -430,10 +430,15 @@ describe('Model', function () {
         assert.deepEqual(modified, { yup: 'yes', nested: {} });
       });
 
-      it.only("When unsetting nested fields, should not create an empty parent to nested field", function () {
+      it("When unsetting nested fields, should not create an empty parent to nested field", function () {
         var obj = model.modify({ argh: true }, { $unset: { 'bad.worse': true } });
+        assert.deepEqual(obj, { argh: true });
 
-        console.log(obj);
+        obj = model.modify({ argh: true, bad: { worse: 'oh' } }, { $unset: { 'bad.worse': true } });
+        assert.deepEqual(obj, { argh: true, bad: {} });
+
+        obj = model.modify({ argh: true, bad: {} }, { $unset: { 'bad.worse': true } });
+        assert.deepEqual(obj, { argh: true, bad: {} });
       });
 
     });   // End of '$unset modifier'