Skip to content

Commit

Permalink
x86, boot: Explicitly include autoconf.h for hostprogs
Browse files Browse the repository at this point in the history
The hostprogs need access to the CONFIG_* symbols found in
include/generated/autoconf.h.  But commit abbf159 ("UAPI: Partition
the header include path sets and add uapi/ header directories") replaced
$(LINUXINCLUDE) with $(USERINCLUDE) which doesn't contain the necessary
include paths.

This has the undesirable effect of breaking the EFI boot stub because
the #ifdef CONFIG_EFI_STUB code in arch/x86/boot/tools/build.c is
never compiled.

It should also be noted that because $(USERINCLUDE) isn't exported by
the top-level Makefile it's actually empty in arch/x86/boot/Makefile.

Cc: H. Peter Anvin <[email protected]>
Cc: Ingo Molnar <[email protected]>
Acked-by: David Howells <[email protected]>
Signed-off-by: Matt Fleming <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Matt Fleming authored and torvalds committed Oct 14, 2012
1 parent 7d380c8 commit b6eea87
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arch/x86/boot/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ setup-y += video-bios.o
targets += $(setup-y)
hostprogs-y := mkcpustr tools/build

HOST_EXTRACFLAGS += -I$(srctree)/tools/include $(USERINCLUDE) \
HOST_EXTRACFLAGS += -I$(srctree)/tools/include \
-include include/generated/autoconf.h \
-D__EXPORTED_HEADERS__

$(obj)/cpu.o: $(obj)/cpustr.h
Expand Down

0 comments on commit b6eea87

Please sign in to comment.