cleaner display of visual metrics

bartekl · May 19, 2016 · 9b10ede · 9b10ede
1 parent 2fd3f62
commit 9b10ede
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/lib/plugins/html/templates/index.jade b/lib/plugins/html/templates/index.jade
@@ -66,12 +66,12 @@ block content
  else
  .one-third.column
  +boxInfo('Backend Time', browsertime.summary.timings.backEndTime)
- if browsertime.visualMetrics
+ if browsertime.summary.visualMetrics
  .row
- .one-third.column
- +boxInfo('Speed Index', browsertime.summary.visualMetrics.SpeedIndex)
  .one-third.column
  +boxInfo('First Visual Change', browsertime.summary.visualMetrics.FirstVisualChange)
+ .one-third.column
+ +boxInfo('Speed Index', browsertime.summary.visualMetrics.SpeedIndex)
  .one-third.column
  +boxInfo('Last Visual Change', browsertime.summary.visualMetrics.LastVisualChange) 
  if webpagetest

diff --git a/lib/plugins/html/templates/url/browsertime/index.jade b/lib/plugins/html/templates/url/browsertime/index.jade
@@ -25,13 +25,13 @@ table
  td.number #{timings.fullyLoaded.toFixed(1)}
  if visualMetrics
  tr
- td SpeedIndex
+ td Speed Index (visual metric)
  td.number #{visualMetrics.SpeedIndex.toFixed(1)}
  tr
- td Render
+ td First Visual Change (visual metric)
  td.number #{visualMetrics.FirstVisualChange.toFixed(1)}
  tr
- td Last visual change
+ td Last Visual Change (visual metric) 
  td.number #{visualMetrics.LastVisualChange.toFixed(1)}
  if (Object.keys(timings.userTimings.marks).length > 0)
  each value, name in timings.userTimings.marks

diff --git a/lib/plugins/html/templates/url/summaryBox.jade b/lib/plugins/html/templates/url/summaryBox.jade
@@ -31,9 +31,8 @@ if pageInfo.data.browsertime
  if btStatistics.visualMetrics
  each visualMetric, name in btStatistics.visualMetrics
  tr
- td(data-title='#{name}') #{name}
- td.number(data-title='min') #{visualMetric.min}
- td.number(data-title='median') #{visualMetric.median}
+ td(data-title='#{name}') #{name} (visual metric)
+ td.number(data-title='min') #{visualMetric.min} td.number(data-title='median') #{visualMetric.median} 
  td.number(data-title='mean') #{visualMetric.mean}
  td.number(data-title='max') #{visualMetric.max}
 else