Skip to content

Fix: Correct broken Basenames OnchainKit tutorial link in FAQ #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

wamimi
Copy link
Contributor

@wamimi wamimi commented Apr 20, 2025

What changed? Why?

Fixed a broken link in the Basenames FAQ section on base.org/names. The "tutorial here" link in the answer to "I am a builder. How do I integrate Basenames to my app?" was pointing to a non-existent URL (https://docs.base.org/docs/basenames-tutorial-with-onchainkit) which returns a 404 error.

This PR updates the link to the correct URL (https://docs.base.org/identity/basenames/basenames-onchainkit-tutorial) to ensure builders can easily access the proper documentation when integrating Basenames into their applications.

Notes to reviewers
This is a simple link correction in the FAQ component. The new link directs to the existing OnchainKit tutorial page that contains the correct integration instructions.

How has it been tested?

  • Verified the new link resolves correctly to the intended OnchainKit tutorial documentation page
  • Confirmed no other functionality is affected by this change

Have you tested the following pages?

BaseWeb

  • base.org/names - Verified the corrected link now works properly in the FAQ section
  • [] base.org
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • docs.base.org/identity/basenames/basenames-onchainkit-tutorial - Verified this page exists and loads correctly
  • [] docs sub-pages

Copy link

vercel bot commented Apr 20, 2025

@wamimi is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 20, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns wbnns enabled auto-merge (squash) April 21, 2025 09:45
@wbnns wbnns added the base docs review To be reviewed by the Base docs team label Apr 21, 2025
@wbnns wbnns merged commit c217f8b into base:master Apr 21, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants