Skip to content

feat: docs services hub #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

feat: docs services hub #2235

merged 4 commits into from
Apr 22, 2025

Conversation

brendan-defi
Copy link
Collaborator

@brendan-defi brendan-defi commented Apr 21, 2025 •
edited
Loading

What changed? Why?

  • added services hub doc to docs

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • docs.base.org
  • docs sub-pages

@vercel Vercel
Copy link

vercel bot commented Apr 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 8:10pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 8:10pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 21, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

xtbase
xtbase approved these changes Apr 22, 2025
View reviewed changes
Copy link

@xtbase xtbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cb-heimdall
Copy link
Collaborator

Review Error for xtbase @ 2025-04-22 22:38:52 UTC
User must have write permissions to review

@brendan-defi brendan-defi merged commit f3883ba into master Apr 22, 2025
9 checks passed
@brendan-defi brendan-defi deleted the feat/services-offers branch April 22, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcramer cpcramer cpcramer approved these changes

@xtbase xtbase xtbase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendan-defi @cb-heimdall @cpcramer @xtbase