Skip to content

chore: add app name to OnchainKitProvider #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

arjun-dureja
Copy link
Contributor

@arjun-dureja arjun-dureja commented Apr 23, 2025

What changed? Why?

  • Passed the app name (Base) to OnchainKitProvider
  • Without the name, OnchainKit defaults to "Dapp", which doesn't look good in the keys.coinbase.com popup

Notes to reviewers

How has it been tested?

  • Manually
Before After

Have you tested the following pages?

BaseWeb

  • base.org
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • base.org/manage-names
  • base.org/resources

BaseDocs

  • docs.base.org
  • docs sub-pages

Copy link

vercel bot commented Apr 23, 2025

@arjun-dureja is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 23, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@arjun-dureja arjun-dureja changed the title Add app name to OnchainKitProvider chore: add app name to OnchainKitProvider Apr 23, 2025
@wbnns wbnns enabled auto-merge (squash) April 23, 2025 16:09
@wbnns wbnns merged commit 84547d0 into base:master Apr 23, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants