Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API-only apps and other apps not using Sprockets or Propshaft #61

Merged
merged 6 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update dev dependencies and docker-compose
And move to propshaft from sprockets.
  • Loading branch information
rosa committed Nov 12, 2024
commit f136fe309f499850025ce7a1bb073a203cbf9c7f
22 changes: 0 additions & 22 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,3 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# Specify your gem's dependencies in audits1984.gemspec.
gemspec

gem 'sqlite3'
gem 'pg'
gem 'mysql2'

group :development do
gem 'rubocop-rails-omakase', require: false
end

group :test do
gem 'minitest'

gem 'rails'
gem 'sprockets-rails'
gem 'puma'

gem 'capybara'
gem 'cuprite'
end

# To use a debugger
# gem 'byebug', group: [:development, :test]
26 changes: 17 additions & 9 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ PATH
specs:
audits1984 (0.1.7)
console1984
importmap-rails (>= 1.2.1)
rinku
rouge
turbo-rails
Expand Down Expand Up @@ -99,6 +100,9 @@ GEM
capybara (~> 3.0)
ferrum (~> 0.14.0)
date (3.3.4)
debug (1.9.2)
irb (~> 1.10)
reline (>= 0.3.8)
erubi (1.12.0)
ferrum (0.14)
addressable (~> 2.5)
Expand All @@ -109,6 +113,10 @@ GEM
activesupport (>= 5.0)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
importmap-rails (2.0.3)
actionpack (>= 6.0.0)
activesupport (>= 6.0.0)
railties (>= 6.0.0)
io-console (0.7.2)
irb (1.14.0)
rdoc (>= 4.0.0)
Expand Down Expand Up @@ -145,6 +153,11 @@ GEM
parser (3.2.2.1)
ast (~> 2.4.1)
pg (1.5.3)
propshaft (1.1.0)
actionpack (>= 7.0.0)
activesupport (>= 7.0.0)
rack
railties (>= 7.0.0)
psych (5.1.2)
stringio
public_suffix (5.0.1)
Expand Down Expand Up @@ -220,13 +233,6 @@ GEM
rubocop-performance
rubocop-rails
ruby-progressbar (1.13.0)
sprockets (4.2.0)
concurrent-ruby (~> 1.0)
rack (>= 2.2.4, < 4)
sprockets-rails (3.4.2)
actionpack (>= 5.2)
activesupport (>= 5.2)
sprockets (>= 3.0.0)
sqlite3 (1.6.3)
mini_portile2 (~> 2.8.0)
stringio (3.1.1)
Expand Down Expand Up @@ -257,13 +263,15 @@ DEPENDENCIES
audits1984!
capybara
cuprite
debug
minitest
mysql2
pg
propshaft
puma
rails
rubocop (~> 1.52.0)
rubocop-performance
rubocop-rails-omakase
sprockets-rails
sqlite3

BUNDLED WITH
Expand Down
14 changes: 14 additions & 0 deletions audits1984.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,20 @@ Gem::Specification.new do |spec|

spec.add_dependency "rouge"
spec.add_dependency "turbo-rails"
spec.add_dependency "importmap-rails", ">= 1.2.1"
spec.add_dependency "rinku"
spec.add_dependency "console1984"

spec.add_development_dependency "sqlite3"
spec.add_development_dependency "pg"
spec.add_development_dependency "mysql2"
spec.add_development_dependency "debug"
spec.add_development_dependency "rubocop", "~> 1.52.0"
spec.add_development_dependency "rubocop-performance"
spec.add_development_dependency "rubocop-rails-omakase"
spec.add_development_dependency "propshaft"
spec.add_development_dependency "puma"
spec.add_development_dependency "minitest"
spec.add_development_dependency "capybara"
spec.add_development_dependency "cuprite"
end
10 changes: 8 additions & 2 deletions bin/setup
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@
set -eu
cd "$(dirname "${BASH_SOURCE[0]}")"

docker-compose up -d --remove-orphans
docker-compose ps
if docker compose version &> /dev/null; then
DOCKER_COMPOSE_CMD="docker compose"
else
DOCKER_COMPOSE_CMD="docker-compose"
fi

$DOCKER_COMPOSE_CMD up -d --remove-orphans
$DOCKER_COMPOSE_CMD ps

bundle

Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ volumes:

services:
mysql:
image: percona:5.7.22
image: mysql:8.0.31
environment:
MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
volumes:
- db:/var/lib/mysql
ports: [ "127.0.0.1:33307:3306" ]
ports: [ "127.0.0.1:33060:3306" ]
postgres:
image: postgres:13.4
environment:
Expand Down