Skip to content

Commit

Permalink
amdkfd: use sizeof(long) granularity for the pasid bitmask
Browse files Browse the repository at this point in the history
All the bit operations (such as find_first_zero_bit()) read sizeof(long) bytes
at a time. If we allocated less than sizeof(long) bytes for the bitmask we
would be accessing invalid memory when working with the bitmask.

Change the allocator to allocate sizeof(long) multiples for the bitmask.

Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Oded Gabbay <[email protected]>
  • Loading branch information
sashalevin authored and Oded Gabbay committed Dec 3, 2014
1 parent d5b75dc commit aeda036
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ int kfd_pasid_init(void)
{
pasid_limit = max_num_of_processes;

pasid_bitmap = kzalloc(DIV_ROUND_UP(pasid_limit, BITS_PER_BYTE),
GFP_KERNEL);
pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
if (!pasid_bitmap)
return -ENOMEM;

Expand Down

0 comments on commit aeda036

Please sign in to comment.