Skip to content

Commit

Permalink
Update header includes for /base/functional in /chrome
Browse files Browse the repository at this point in the history
bind.h, callback.h, callback_forward.h, and callback_helpers.h
moved into /base/functional/. Update the include paths to
directly include them in their new location.

Bug: 1364441
Change-Id: I55002575f6d57fe2be070c64acabc2e1ba0a2222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4145905
Auto-Submit: Avi Drissman <[email protected]>
Owners-Override: Avi Drissman <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1090501}
  • Loading branch information
Avi Drissman authored and Chromium LUCI CQ committed Jan 9, 2023
1 parent c74cc6f commit 17b3490
Show file tree
Hide file tree
Showing 54 changed files with 73 additions and 73 deletions.
2 changes: 1 addition & 1 deletion alert_commands.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include <memory>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/chrome.h"
#include "chrome/test/chromedriver/chrome/devtools_client.h"
Expand Down
2 changes: 1 addition & 1 deletion alert_commands.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <memory>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"
#include "base/values.h"

struct Session;
Expand Down
4 changes: 2 additions & 2 deletions capabilities.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#include <map>
#include <utility>

#include "base/bind.h"
#include "base/callback.h"
#include "base/containers/fixed_flat_set.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/json/string_escape.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
Expand Down
4 changes: 2 additions & 2 deletions chrome/adb_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

#include "chrome/test/chromedriver/chrome/adb_impl.h"

#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/environment.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/json/string_escape.h"
#include "base/logging.h"
#include "base/memory/ref_counted.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/bidi_tracker.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <map>
#include <string>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"

Expand Down
4 changes: 2 additions & 2 deletions chrome/chrome_finder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
#include <vector>

#include "base/base_paths.h"
#include "base/bind.h"
#include "base/callback.h"
#include "base/environment.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/logging.h"
#include "base/path_service.h"
#include "base/strings/string_split.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_finder.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <vector>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"

namespace base {
class FilePath;
Expand Down
4 changes: 2 additions & 2 deletions chrome/chrome_finder_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#include <string>
#include <vector>

#include "base/bind.h"
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "chrome/test/chromedriver/chrome/chrome_finder.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#include <memory>
#include <utility>

#include "base/bind.h"
#include "base/check.h"
#include "base/functional/bind.h"
#include "base/logging.h"
#include "base/ranges/algorithm.h"
#include "base/strings/string_number_conversions.h"
Expand Down
6 changes: 3 additions & 3 deletions chrome/device_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@

#include <vector>

#include "base/bind.h"
#include "base/callback.h"
#include "base/callback_helpers.h"
#include "base/check.h"
#include "base/containers/contains.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/functional/callback_helpers.h"
#include "base/ranges/algorithm.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/device_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <memory>
#include <string>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/synchronization/lock.h"

Expand Down
2 changes: 1 addition & 1 deletion chrome/devtools_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <memory>
#include <string>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"
#include "base/values.h"

class DevToolsEventListener;
Expand Down
2 changes: 1 addition & 1 deletion chrome/devtools_client_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#include <sstream>
#include <utility>

#include "base/bind.h"
#include "base/check.h"
#include "base/functional/bind.h"
#include "base/i18n/message_formatter.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/devtools_client_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <memory>
#include <string>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_refptr.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/devtools_client_impl_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
#include <string>
#include <utility>

#include "base/bind.h"
#include "base/compiler_specific.h"
#include "base/functional/bind.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
Expand Down
4 changes: 2 additions & 2 deletions chrome/devtools_http_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#include <memory>
#include <utility>

#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/containers/contains.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/json/json_reader.h"
#include "base/strings/string_util.h"
#include "base/threading/platform_thread.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/javascript_dialog_manager_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include <memory>
#include <string>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/browser_info.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/web_view.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <string>
#include <vector>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"
#include "base/values.h"

namespace base {
Expand Down
2 changes: 1 addition & 1 deletion chrome/web_view_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
#include <utility>
#include <vector>

#include "base/bind.h"
#include "base/check.h"
#include "base/files/file_path.h"
#include "base/functional/bind.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/web_view_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <memory>
#include <string>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/memory/raw_ptr.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/web_view.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome/web_view_impl_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#include <queue>
#include <string>

#include "base/bind.h"
#include "base/compiler_specific.h"
#include "base/functional/bind.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/memory/raw_ptr.h"
Expand Down
2 changes: 1 addition & 1 deletion chrome_launcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
#include <vector>

#include "base/base64.h"
#include "base/bind.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_file.h"
#include "base/format_macros.h"
#include "base/functional/bind.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
Expand Down
2 changes: 1 addition & 1 deletion command.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <memory>
#include <string>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"
#include "base/values.h"

class Status;
Expand Down
4 changes: 2 additions & 2 deletions commands.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
#include <list>
#include <utility>

#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/containers/contains.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/location.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
Expand Down
2 changes: 1 addition & 1 deletion commands.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <memory>
#include <string>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"
#include "base/values.h"
#include "chrome/test/chromedriver/command.h"
#include "chrome/test/chromedriver/session_thread_map.h"
Expand Down
4 changes: 2 additions & 2 deletions commands_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
#include <utility>
#include <vector>

#include "base/bind.h"
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/location.h"
#include "base/run_loop.h"
#include "base/synchronization/lock.h"
Expand Down
2 changes: 1 addition & 1 deletion element_commands.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
#include <unordered_set>
#include <vector>

#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/functional/callback.h"
#include "base/logging.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion element_commands.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <memory>
#include <string>

#include "base/callback_forward.h"
#include "base/functional/callback_forward.h"
#include "base/values.h"

struct Session;
Expand Down
4 changes: 2 additions & 2 deletions net/adb_client_socket.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
#include <memory>
#include <utility>

#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/compiler_specific.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion net/adb_client_socket.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#ifndef CHROME_TEST_CHROMEDRIVER_NET_ADB_CLIENT_SOCKET_H_
#define CHROME_TEST_CHROMEDRIVER_NET_ADB_CLIENT_SOCKET_H_

#include "base/callback.h"
#include "base/functional/callback.h"
#include "net/base/completion_once_callback.h"
#include "net/base/io_buffer.h"
#include "net/socket/stream_socket.h"
Expand Down
2 changes: 1 addition & 1 deletion net/adb_client_socket_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include <memory>

#include "base/bind.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/test/gtest_util.h"
Expand Down
4 changes: 2 additions & 2 deletions net/net_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

#include <memory>

#include "base/bind.h"
#include "base/callback_helpers.h"
#include "base/compiler_specific.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/lazy_instance.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/stringprintf.h"
Expand Down
2 changes: 1 addition & 1 deletion net/net_util_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
#include <string>
#include <utility>

#include "base/bind.h"
#include "base/compiler_specific.h"
#include "base/functional/bind.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/ref_counted.h"
Expand Down
2 changes: 1 addition & 1 deletion net/pipe_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <memory>

#include "base/base64.h"
#include "base/bind.h"
#include "base/functional/bind.h"
#include "build/build_config.h"
#include "chrome/test/chromedriver/net/pipe_handler.h"
#include "net/base/io_buffer.h"
Expand Down
2 changes: 1 addition & 1 deletion net/sync_websocket_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#include <memory>

#include "base/bind.h"
#include "base/command_line.h"
#include "base/functional/bind.h"
#include "base/memory/ref_counted.h"
#include "chrome/test/chromedriver/log_replay/log_replay_socket.h"
#include "chrome/test/chromedriver/net/sync_websocket_impl.h"
Expand Down
2 changes: 1 addition & 1 deletion net/sync_websocket_factory.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include <memory>

#include "base/callback.h"
#include "base/functional/callback.h"

class SyncWebSocket;
class URLRequestContextGetter;
Expand Down
4 changes: 2 additions & 2 deletions net/sync_websocket_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#include <memory>

#include "base/bind.h"
#include "base/callback.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/location.h"
Expand Down
2 changes: 1 addition & 1 deletion net/sync_websocket_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <memory>
#include <string>

#include "base/callback.h"
#include "base/functional/callback.h"
#include "base/memory/ref_counted.h"
#include "base/synchronization/condition_variable.h"
#include "base/synchronization/lock.h"
Expand Down
Loading

0 comments on commit 17b3490

Please sign in to comment.