Skip to content

Commit

Permalink
Fix codebase in preparation for incompatible_use_cc_configure_from_ru…
Browse files Browse the repository at this point in the history
…les_cc

We're working on removing C++ toolchain autoconfiguration logic out of Bazel,
and moving towards using rules_cc repository for it. Some bzl files will no
longer be available through bazel/tools/cpp/*, but through
@rules_cc/cc/*.

RELNOTES: None.
PiperOrigin-RevId: 279935457
  • Loading branch information
hlopko authored and copybara-github committed Nov 12, 2019
1 parent 7aa0d5b commit 1bc6fe2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ public void setup() throws Exception {
scratch.overwriteFile(
"/bazel_tools_workspace/tools/build_defs/cc/action_names.bzl",
ResourceLoader.readFromResources(
TestConstants.BAZEL_REPO_PATH + "tools/build_defs/cc/action_names.bzl"));
TestConstants.RULES_CC_REPOSITORY_EXECROOT + "cc/action_names.bzl"));

scratch.overwriteFile(
"/bazel_tools_workspace/tools/cpp/cc_toolchain_config_lib.bzl",
ResourceLoader.readFromResources(
TestConstants.BAZEL_REPO_PATH + "tools/cpp/cc_toolchain_config_lib.bzl"));
TestConstants.RULES_CC_REPOSITORY_EXECROOT + "cc/cc_toolchain_config_lib.bzl"));
scratch.file("/ndk/source.properties", "Pkg.Desc = Android NDK", "Pkg.Revision = 13.1.3345770");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public Path create(String relativePath, String... lines) throws IOException {
newContent.append(System.lineSeparator());
}

if (!newContent.toString().equals(existingContent)) {
if (!newContent.toString().trim().equals(existingContent.trim())) {
throw new IOException(
"Conflict: '"
+ relativePath
Expand Down

0 comments on commit 1bc6fe2

Please sign in to comment.