Skip to content

Commit

Permalink
Fix typo
Browse files Browse the repository at this point in the history
RELNOTES: None.
PiperOrigin-RevId: 275234136
  • Loading branch information
hlopko authored and copybara-github committed Oct 17, 2019
1 parent 2491ed3 commit f6c4b69
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ public static String computeCcFlags(RuleContext ruleContext, TransitiveInfoColle
// will be gone.
String sysrootCcFlags =
computeCcFlagForSysroot(
toolchainProvider.getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas(),
toolchainProvider.getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas(),
toolchainProvider);

// Fetch additional flags from the FeatureConfiguration.
Expand Down Expand Up @@ -1022,7 +1022,7 @@ private static List<String> computeCcFlagsFromFeatureConfig(
cppConfiguration = ruleContext.getFragment(CppConfiguration.class);
} else {
cppConfiguration =
toolchainProvider.getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas();
toolchainProvider.getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas();
}
try {
featureConfiguration =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public FeatureConfigurationForStarlark configureFeatures(
}
CppConfiguration cppConfiguration =
ruleContext == null
? toolchain.getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas()
? toolchain.getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas()
: ruleContext.getRuleContext().getFragment(CppConfiguration.class);
// buildOptions are only used when --incompatible_enable_cc_toolchain_resolution is flipped,
// and that will only be flipped when --incompatible_require_ctx_in_configure_features is
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ public NestedSet<Artifact> getCoverageFiles() {
}

public NestedSet<Artifact> getLibcLink(CppConfiguration cppConfiguration) {
if (cppConfiguration.equals(getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas())) {
if (cppConfiguration.equals(getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas())) {
return libcLink;
} else {
return targetLibcLink;
Expand Down Expand Up @@ -696,7 +696,7 @@ public boolean supportsInterfaceSharedLibraries(FeatureConfiguration featureConf
* <p>Once toolchain transitions are implemented, we can safely use the CppConfiguration from the
* toolchain in rules.
*/
CppConfiguration getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas() {
CppConfiguration getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas() {
return cppConfiguration;
}

Expand Down Expand Up @@ -727,7 +727,7 @@ public CcToolchainVariables getBuildVariables(
* @param cppConfiguration
*/
public ImmutableList<Artifact> getBuiltinIncludeFiles(CppConfiguration cppConfiguration) {
if (cppConfiguration.equals(getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas())) {
if (cppConfiguration.equals(getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas())) {
return builtinIncludeFiles;
} else {
return targetBuiltinIncludeFiles;
Expand Down Expand Up @@ -756,7 +756,7 @@ public String getSysroot() {
}

public PathFragment getSysrootPathFragment(CppConfiguration cppConfiguration) {
if (cppConfiguration.equals(getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas())) {
if (cppConfiguration.equals(getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas())) {
return sysroot;
} else {
return targetSysroot;
Expand Down Expand Up @@ -953,7 +953,7 @@ public PathFragment getDefaultSysroot() {
}

public boolean requireCtxInConfigureFeatures() {
return getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas()
return getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas()
.requireCtxInConfigureFeatures();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ protected void computeKey(ActionKeyContext actionKeyContext, Fingerprint fp)
cppCompileActionBuilder.getBuiltinIncludeDirectories(),
cppCompileActionBuilder.buildInputsForInvalidation(),
toolchain
.getCppConfigurationEvenThoughItCanBeDifferentThatWhatTargetHas()
.getCppConfigurationEvenThoughItCanBeDifferentThanWhatTargetHas()
.validateTopLevelHeaderInclusions());
}

Expand Down

0 comments on commit f6c4b69

Please sign in to comment.