Makefile: remove dependency-tracking and auto-cleaning #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency-tracking winds up creating issues with wanting to run a "make install" after a "make release" - since the Makefile was calling "mkdir -p" to auto-create object and dependency folders, timestamps would (maybe) be updated and cause a rebuild using default CFLAGS/CXXFLAGS. "maybe" because it differed based on what operating system was in use. This simplifies things a bit - a user can just run their own "make clean" if they need a rebuild with different flags, now object file timestamps will only be compared against their source file timestamps and not trigger unnecessary rebuilds. The dependency-tracking for Make doesn't seem to make a big difference with regard to build times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency-tracking winds up creating issues with
wanting to run a "make install" after a "make release" -
since the Makefile was calling "mkdir -p" to auto-create object
and dependency folders, timestamps would (maybe) be updated and cause
a rebuild using default CFLAGS/CXXFLAGS. "maybe" because it differed
based on what operating system was in use.
This simplifies things a bit - a user can just run their own "make
clean" if they need a rebuild with different flags, now object file
timestamps will only be compared against their source file timestamps
and not trigger unnecessary rebuilds. The dependency-tracking for Make
doesn't seem to make a big difference with regard to build times.
This also auto-sets default CFLAGS/CXXFLAGS if not given (a user
running "make demo" with no other flags would trigger this).