run static analysis in CI

.github/workflows/tests.yml

@@ -11,5 +11,8 @@ jobs:
     - uses: actions/checkout@v2
     - name: Build docker image
       run: docker build -t rednose .
+    - name: Static analysis
+      run: |
+        docker run cereal bash -c "git init && git add -A && pre-commit run --all"
     - name: Unit Tests
       run: docker run rednose bash -c "cd /project/rednose/examples; python -m unittest discover"

.pre-commit-config.yaml

@@ -0,0 +1,27 @@
+repos:
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: master
+    hooks:
+    -   id: check-ast
+    -   id: check-json
+    -   id: check-xml
+    -   id: check-yaml
+-   repo: https://github.com/pre-commit/mirrors-mypy
+    rev: master
+    hooks:
+    -   id: mypy
+-   repo: https://gitlab.com/PyCQA/flake8
+    rev: master
+    hooks:
+    -   id: flake8
+        args:
+        - --select=F
+-   repo: local
+    hooks:
+    -   id: pylint
+        name: pylint
+        entry: pylint
+        language: system
+        types: [python]
+        args:
+        - --disable=R,C,W

Dockerfile

@@ -7,12 +7,13 @@ ENV PATH="/root/.pyenv/bin:/root/.pyenv/shims:${PATH}"
 RUN pyenv install 3.7.3
 RUN pyenv global 3.7.3
 RUN pyenv rehash
-RUN pip3 install scons==3.1.1
+RUN pip3 install scons==3.1.1 pre-commit==2.4.0 pylint==2.5.2
 
 WORKDIR /project/rednose
 
 ENV PYTHONPATH=/project
 
 COPY . .
+RUN rm -rf .git
 RUN python3 setup.py install
 RUN scons -c && scons -j$(nproc)

examples/test_kinematic_kf.py

@@ -2,7 +2,7 @@
 import numpy as np
 import unittest
 
-from kinematic_kf import KinematicKalman, ObservationKind, States
+from kinematic_kf import KinematicKalman, ObservationKind, States  # pylint: disable=import-error
 
 GENERATED_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), 'generated'))
 
@@ -55,7 +55,7 @@ def test_kinematic_kf(self):
     self.assertAlmostEqual(vs_kf_std[-1], 0.6695762270974388)
 
     if "PLOT" in os.environ:
-      import matplotlib.pyplot as plt
+      import matplotlib.pyplot as plt  # pylint: disable=import-error
       plt.figure()
       plt.subplot(2, 1, 1)
       plt.plot(ts, xs, 'k', label='Simulation')

rednose/helpers/sympy_helpers.py

@@ -49,7 +49,7 @@ def euler2quat(eulers):
   quats = np.array([q0, q1, q2, q3]).T
   for i in range(len(quats)):
     if quats[i,0] < 0:
-      quats[i] = -quats[i]
+      quats[i] = -quats[i]  # pylint: disable=unsupported-assignment-operation
   return quats.reshape(output_shape)