qsort(indexes=TRUE) #371
Open
qsort(indexes=TRUE) #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alain-Bearez
commented
Dec 7, 2017
| @@ -239,22 +271,24 @@ public static IntVector psort(IntVector x, Vector indexes) { | |||
|
|
|||
|
|
|||
| @Internal | |||
| public static LogicalVector qsort(LogicalVector x, boolean returnIndexes) { | |||
There was a problem hiding this comment.
Why is returnIndexes a boolean here while it is defined as LogicalVector on the two other methods?
akbertram
force-pushed
the
master
branch
2 times, most recently
from
ef9d981 to
efef981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation might be under optimal as it sorts indices (as
Integer) by comparing their referenced values.