Fix script issue with double quotes in DISTRO_ID extraction #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumithemmadi
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
|
Thank you for the fix. I will examine the problem and might revert the commit that broke it |
|
I reverted my commit. Can you please confirm that it is working again? |
|
Yes it's working.
|
|
Thank you. I will close this PR. Can you DM in the BeEF discord channel |
|
Sure |
This reverts commit 61528a4.
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.12.0 to 4.13.1. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/commits) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.56.3 to 1.56.4. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.3...v1.56.4) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
wheatley
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for your contribution! Please complete this PR template with the relevant information.
Category
Bug
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: This pull request addresses a bug related to the extraction of
DISTRO_IDin the script.The command
grep ID= /etc/os-release | grep -v "BUILD" | grep -v "IMAGE" | cut -d= -f2-returned the value"endeavouros"with double quotes, which caused issues in subsequent script checks.To provide some context, in a previous pull request, #2930, I introduced the double quotes around
endeavourosto match the expected format. However, @stephenakq removed the double quotes in 624176e commit.I've modified the command to remove the double quotes, resulting in the expected value
endeavouros.Q: Give a technical rundown of what you have changed (if applicable)
A: I have modified the command responsible for extracting
DISTRO_IDfrom/etc/os-release. The change ensures that the extracted value is stored without double quotes using thesedcommand.Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: I have thoroughly tested this change on various Linux distributions, including EndeavourOS, to ensure it correctly extracts and stores the
DISTRO_IDwithout double quotes. The script now functions as expected on these distributions.