Add a Windows prompt to the pretty_theft module #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antisnatchor
added a commit
that referenced
this pull request
Apr 14, 2014
Add a Windows prompt to the pretty_theft module
|
Thanks for this man ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Windows 7 network security prompt to the pretty_theft module. I have removed the section where the remote server is listed, and removed the cancel button in an attempt to force the user into submitting credentials. Similarly, there is no close window button on the popup.
It was necessary to modify checker() to retrieve input data using the ID instead of the element tag as the "remember my credentials" option throws off the counts. As the existing functions use the same ID names for their fields, this should not change the functionality.
There is a couple of more CSS changes that are needed to bring it fully in line with the standard prompt, but is enough to pass a cursory inspection in its current state.