Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dns to support regex + fixed loop + fixed assumptions #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eyJhb
Copy link

@eyJhb eyJhb commented Jan 5, 2023

Initially I couldn't get tinydns to run at all, which was fixed in the commit below.
As well as added support for using regex for domains, which could maybe be enabled/disabled (for usecases where it's not needed).
Besides this, some assumptions was made about the structure of the question packet, which was not always true, ie. when using dig it would send additional information, which this library did not handle well.
Now it parses the response one byte at a time,instead of reading at the end.

Things that should be fixed

  • Make flag to enable/disable regex
  • enable/disable regex should use simple compare, and maybe use the previous implementation to use less memory
  • Remove last . in domain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant