Skip to content

Commit

Permalink
Removed minimum breadcrumb width option
Browse files Browse the repository at this point in the history
  • Loading branch information
benji300 committed Mar 3, 2021
1 parent de5b9a7 commit d2c82e1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 16 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Plugin command labels (Removed `Tabs:` prefix)
- Breadcrumbs and navigation icon styles

### Removed

- User option to specify minimum width of a single breadcrumb (`Minimum breadcrumb width (px)`)

## [1.2.1] - 2021-02-23

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/panel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export class Panel {

parentsHtml.push(`
<div class="breadcrumb" data-id="${parent.id}" onClick="openFolder(event);"
style="min-width:${this.sets.breadcrumbsMinWidth}px;max-width:${this.sets.breadcrumbsMaxWidth}px;">
style="max-width:${this.sets.breadcrumbsMaxWidth}px;">
<span class="breadcrumb-inner">
<a href="#" class="breadcrumb-title" style="color:${this.sets.foreground};" title="${parent.title}">${parent.title}</a>
<span class="fas fa-chevron-right" style="color:${this.sets.foreground};"></span>
Expand Down
15 changes: 0 additions & 15 deletions src/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export class Settings {
private _tabHeight: number = 35;
private _minTabWidth: number = 50;
private _maxTabWidth: number = 150;
private _breadcrumbsMinWidth: number = 10;
private _breadcrumbsMaxWidth: number = 100;
private _fontFamily: string = SettingDefaults.Default;
private _fontSize: string = SettingDefaults.Default;
Expand Down Expand Up @@ -116,10 +115,6 @@ export class Settings {
return this._maxTabWidth;
}

get breadcrumbsMinWidth(): number {
return this._breadcrumbsMinWidth;
}

get breadcrumbsMaxWidth(): number {
return this._breadcrumbsMaxWidth;
}
Expand Down Expand Up @@ -297,15 +292,6 @@ export class Settings {
label: 'Maximum Tab width (px)',
description: 'Maximum width of one tab in pixel.'
});
await joplin.settings.registerSetting('breadcrumbsMinWidth', {
value: this._breadcrumbsMinWidth,
type: SettingItemType.Int,
section: 'note.tabs.settings',
public: true,
advanced: true,
label: 'Minimum breadcrumb width (px)',
description: 'Minimum width of one breadcrumb in pixel.'
});
await joplin.settings.registerSetting('breadcrumbsMaxWidth', {
value: this._breadcrumbsMaxWidth,
type: SettingItemType.Int,
Expand Down Expand Up @@ -429,7 +415,6 @@ export class Settings {
this._tabHeight = await this.getOrDefault(event, this._tabHeight, 'tabHeight');
this._minTabWidth = await this.getOrDefault(event, this._minTabWidth, 'minTabWidth');
this._maxTabWidth = await this.getOrDefault(event, this._maxTabWidth, 'maxTabWidth');
this._breadcrumbsMinWidth = await this.getOrDefault(event, this._breadcrumbsMinWidth, 'breadcrumbsMinWidth');
this._breadcrumbsMaxWidth = await this.getOrDefault(event, this._breadcrumbsMaxWidth, 'breadcrumbsMaxWidth');
this._fontFamily = await this.getOrDefault(event, this._fontFamily, 'fontFamily', SettingDefaults.FontFamily);
this._fontSize = await this.getOrDefault(event, this._fontSize, 'fontSize', SettingDefaults.FontSize);
Expand Down

0 comments on commit d2c82e1

Please sign in to comment.