Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Restore the functionality of the '--disable-symvers' switch. #159

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

besser82
Copy link
Owner

@besser82 besser82 commented Nov 1, 2022

Without this change the build was simply broken, if symbol versioning was disabled for any reason, e.g. whether the compiler nor the linker supporting it, or if disabled on purpose by the user.

Also adapt the testsuite and the CI test-matrix.

Fixes #142.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 88.58% // Head: 88.58% // No change to project coverage 👍

Coverage data is based on head (f5353e2) compared to base (13435fd).
Patch has no changes to coverable lines.

❗ Current head f5353e2 differs from pull request most recent head edd2adb. Consider uploading reports for the commit edd2adb to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #159   +/-   ##
========================================
  Coverage    88.58%   88.58%           
========================================
  Files           32       32           
  Lines         3618     3618           
  Branches       690      690           
========================================
  Hits          3205     3205           
  Misses         228      228           
  Partials       185      185           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@besser82 besser82 force-pushed the topic/besser82/disable_symvers branch from 26e44d4 to 7e87386 Compare November 1, 2022 11:28
Without this change the build was simply broken, if symbol versioning
was disabled for any reason, e.g. whether the compiler nor the linker
supporting it, or if disabled on purpose by the user.

Also adapt the testsuite and the CI test-matrix.

Fixes #142.

Signed-off-by: Björn Esser <[email protected]>
@besser82 besser82 force-pushed the topic/besser82/disable_symvers branch 2 times, most recently from 3f2a09a to edd2adb Compare November 1, 2022 13:26
@besser82 besser82 merged commit edd2adb into develop Nov 1, 2022
@besser82 besser82 deleted the topic/besser82/disable_symvers branch November 1, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with no symbol versioning is broken
2 participants