Remove smartmatch usage from gen-crypt-h #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for Perl 5.38
|
@besser82 Could you take a look? Perl 5.38 is now out. Cheers! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #172 +/- ##
========================================
Coverage 89.87% 89.87%
========================================
Files 32 32
Lines 3626 3626
Branches 690 690
========================================
Hits 3259 3259
Misses 227 227
Partials 140 140 ☔ View full report in Codecov by Sentry. |
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also needed for building with Perl 5.38... another smartmatch usage that now triggers a deprecation warning.
BTW, it's really a bad idea to treat these warnings all as errors. Otherwise we'd get a warning now, but not a failure... more time to fix stuff...