Check whether the linker can use version-script files. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besser82
force-pushed
the
besser82/configure_version_script
branch
2 times, most recently
from
0fa074d to
36f6253
Compare
Codecov Report
@@ Coverage Diff @@
## develop #48 +/- ##
========================================
Coverage 90.04% 90.04%
========================================
Files 32 32
Lines 3204 3204
========================================
Hits 2885 2885
Misses 319 319
Continue to review full report at Codecov.
|
besser82
force-pushed
the
besser82/configure_version_script
branch
2 times, most recently
from
7bb2fb9 to
7a11bea
Compare
zackw
approved these changes
Oct 31, 2018
There was a problem hiding this comment.
I have some minor concerns, and I am not sure I understand the connection to #46, but hopefully it will become clear. This seems like a worthwhile change in its own right, anyway.
There are several unrelated commits in this PR. I haven't really reviewed those but I don't have a problem with them.
besser82
force-pushed
the
besser82/configure_version_script
branch
from
d26411b to
b548469
Compare
|
Will merge after TravisCI goes green. |
|
Rebase merged on cli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.