-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements to Autotools. #82
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #82 +/- ##
========================================
Coverage 96.39% 96.39%
========================================
Files 32 32
Lines 3109 3109
========================================
Hits 2997 2997
Misses 112 112
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #82 +/- ##
========================================
Coverage 96.39% 96.39%
========================================
Files 32 32
Lines 3109 3109
========================================
Hits 2997 2997
Misses 112 112
Continue to review full report at Codecov.
|
@zackw Are you fine with this change? |
d2e9886
to
c08aa84
Compare
Rebased onto develop, squashed all previous commits into one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Sorry to keep you waiting, I was very busy the past couple days, and I always have to think carefully about changes to the configure script that are more complicated than adding another entry to the AC_CHECK_FUNCS
list.
I have a few line notes but none of them is critical.
We need at least Python >= 3.6 and several Python modules to run test-crypt-kat-gen.py for updating test-crypt-kat.inc.
c08aa84
to
0f0c90a
Compare
Fixes are in the rebased commit. Will merge on CLI as soon as Travis turns green. |
Basically this adds some sanity checks in configure around the
regen-test-crypt-kat
target in Makefile.