Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to Autotools. #82

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

besser82
Copy link
Owner

@besser82 besser82 commented Feb 6, 2019

Basically this adds some sanity checks in configure around the regen-test-crypt-kat target in Makefile.

@besser82 besser82 requested a review from zackw February 6, 2019 15:35
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #82 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #82   +/-   ##
========================================
  Coverage    96.39%   96.39%           
========================================
  Files           32       32           
  Lines         3109     3109           
========================================
  Hits          2997     2997           
  Misses         112      112
Impacted Files Coverage Δ
alg-yescrypt-opt.c 97.58% <0%> (-0.22%) ⬇️
crypt-nthash.c 89.28% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c1f65...8774c4e. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #82 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #82   +/-   ##
========================================
  Coverage    96.39%   96.39%           
========================================
  Files           32       32           
  Lines         3109     3109           
========================================
  Hits          2997     2997           
  Misses         112      112
Impacted Files Coverage Δ
crypt-pbkdf1-sha1.c 97.29% <0%> (-1.36%) ⬇️
crypt-sunmd5.c 99.07% <0%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a7ada6...0f0c90a. Read the comment docs.

@besser82
Copy link
Owner Author

besser82 commented Feb 6, 2019

@zackw Are you fine with this change?

@besser82 besser82 force-pushed the besser82/configure_python branch from d2e9886 to c08aa84 Compare February 6, 2019 22:24
@besser82
Copy link
Owner Author

besser82 commented Feb 6, 2019

Rebased onto develop, squashed all previous commits into one.

Copy link
Collaborator

@zackw zackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Sorry to keep you waiting, I was very busy the past couple days, and I always have to think carefully about changes to the configure script that are more complicated than adding another entry to the AC_CHECK_FUNCS list.

I have a few line notes but none of them is critical.

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
configure.ac Show resolved Hide resolved
We need at least Python >= 3.6 and several Python modules to
run test-crypt-kat-gen.py for updating test-crypt-kat.inc.
@besser82 besser82 force-pushed the besser82/configure_python branch from c08aa84 to 0f0c90a Compare February 7, 2019 20:18
@besser82
Copy link
Owner Author

besser82 commented Feb 7, 2019

Fixes are in the rebased commit. Will merge on CLI as soon as Travis turns green.

@besser82 besser82 merged commit 0f0c90a into develop Feb 7, 2019
@besser82 besser82 deleted the besser82/configure_python branch February 7, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants