Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode MIME headers for better readability in web interface. #42

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from

Conversation

petrkle
Copy link

@petrkle petrkle commented Nov 8, 2012

Hi,

this change "Subject: =?UTF-8?B?UMWZa....." to readable version.

Cheers
Petr

@tsibley
Copy link
Contributor

tsibley commented Nov 8, 2012

I'm not sure we actually want this behaviour. It is often useful to see exactly what RT sent out, and munging that on display means you then need to go poking through the database.

@ruz
Copy link
Contributor

ruz commented Nov 9, 2012

On Thu, Nov 8, 2012 at 10:14 PM, Thomas Sibley [email protected]:

I'm not sure we actually want this behaviour. It is often useful to see
exactly what RT sent out, and munging that on display means you then need
to go poking through the database.

Good variant is to put a tag around with decoded value in title attribute
so decoded value can be seen on mouse over.


Reply to this email directly or view it on GitHubhttps://github.com//pull/42#issuecomment-10198556.

Best regards, Ruslan.

@petrkle
Copy link
Author

petrkle commented Nov 9, 2012

It would be nice that ordinary user can read subject and sender of outgoing messages. Especialy in non-ascii countries. Admins can change preferences to show raw headers.

http://git.io/oY9CCw

@netsandbox
Copy link
Contributor

I like @ruz idea. You can see the decoded and encoded version without switching a config option.

@tsibley
Copy link
Contributor

tsibley commented Nov 9, 2012

On 11/09/2012 06:27 AM, Petr wrote:

It would be nice that ordinary user can read subject and sender of
outgoing messages. Especialy in non-ascii countries. Admins can change
preferences to show raw headers.

Ordinary users generally don't scan through full email headers to find
the Subject and recipients/sender.

I don't think this warrants a config option or user preference. I
prefer @ruz's suggestion.

@petrkle
Copy link
Author

petrkle commented Nov 12, 2012

Not optimal in my opinion, but better than nothing.

@petrkle petrkle closed this Dec 10, 2012
@tsibley
Copy link
Contributor

tsibley commented Dec 12, 2012

Why did you close this request without the commit being merged?

@tsibley tsibley reopened this Dec 12, 2012
@petrkle
Copy link
Author

petrkle commented Dec 13, 2012

After a month, nothing happened.

@tsibley
Copy link
Contributor

tsibley commented Dec 13, 2012

On 12/13/2012 05:06 AM, Petr wrote:

After a month, nothing happened.

We're a busy team. Not everything gets dealt with within a month. :)

I agree that it would be useful to have some sort of decoding of
headers, and I think the tooltip solution is a good compromise. It
requires someone with a little bit of time to do some testing, but
otherwise it should be a shoo-in for the RT 4.2 series (master branch
currently).

Looking at your latest patch more closely, my main concern is that it
runs decode("MIME-Headers", ...) over the entire header block, rather
than on individual headers.

jibsheet added a commit that referenced this pull request Mar 7, 2013
This allows us to remove the ugly code in ShowLink and make it ugly in
here instead.

This means that Formats which say __RefersTo__ or __HasMember__ will
now say "ticket #42: Ticket Subject" rather than the current state of
the world where that renders as "ticket #42" which is not helpful.

The code in rt.pm's AsString is ugly because it assumes that you might
use this on some non-RT::Ticket object.  That never really happens, but
all of this code pretends it might happen so I kept up the illusion.
jibsheet added a commit that referenced this pull request Mar 7, 2013
It looks really odd that we say 'ticket' but every other link type is
ucfirsted.  However, we rely on that hardcoded lowercase 'ticket'
(hardcoded in ObjectType) in HREF and other link building code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants