Skip to content

DEVDOCS-6208: [update] add note for site domain tables #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2025
Merged

DEVDOCS-6208: [update] add note for site domain tables #855

merged 8 commits into from
Apr 25, 2025

Conversation

bc-traciporter
Copy link
Contributor

@bc-traciporter bc-traciporter commented Mar 10, 2025 •
edited by jira bot
Loading

DEVDOCS-6208

What changed?

Added a note

Release notes draft

Anything else?

ping {names}

@bc-traciporter bc-traciporter requested a review from a team as a code owner March 10, 2025 18:09
@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Mar 11, 2025
pokatos
pokatos reviewed Mar 18, 2025
View reviewed changes
Copy link

@pokatos pokatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bc-traciporter
Changes look good.
Before approving this PR, I wonder to find out when it will be merged to understand if our code in sites-service is align with changes in docs.

@bc-traciporter bc-traciporter added pending-production-release and removed ready for review This PR is complete and awaiting a review. labels Mar 18, 2025
@bc-traciporter
Copy link
Contributor Author

bc-traciporter commented Mar 18, 2025 •
edited
Loading

hey @bc-traciporter Changes look good. Before approving this PR, I wonder to find out when it will be merged to understand if our code in sites-service is align with changes in docs.

I will need to wait to merge this PR. The GA date is now May 1, 2025. Thank you for reviewing @pokatos .

@bc-traciporter
Copy link
Contributor Author

Hi @pokatos I just learned that this feature is being released now. I am not sure how to answer your question above.

@DmytroSirenko
Copy link

hey @bc-traciporter Changes look good. Before approving this PR, I wonder to find out when it will be merged to understand if our code in sites-service is align with changes in docs.

Development documentation should be merged when rollout reaches 25% of all stores i.e. today, April 24.

pokatos
pokatos approved these changes Apr 25, 2025
View reviewed changes
Copy link

@pokatos pokatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes under LD FF are enabled on 25% now.

@bc-traciporter bc-traciporter merged commit f9e0ddf into main Apr 25, 2025
3 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-6208 branch April 25, 2025 13:24
@github-actions github-actions bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroSirenko DmytroSirenko DmytroSirenko left review comments

@pokatos pokatos pokatos approved these changes

@bc-terra bc-terra bc-terra approved these changes

Assignees
No one assigned
Labels
pending-production-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bc-traciporter @DmytroSirenko @pokatos @bc-terra