Prefix SKU from model field or default to using the source on config as a string #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as a string -Check if the specified source field in the config file exists on the model, if not then use the source field as a string to prefix the SKU.
|
I would rather create SKU generator contract and offer an alternative implementation, but that is just me. |
|
@talelmishali you are not forgotten; you just reminded me of the original plan. Hold on tight, a new version is coming up |
|
@talelmishali take a look at #13 |
|
A very elegant solution, working great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Came across the need to default the SKU prefix to a predefined string and not necessarily based on a field from the model.
-Check if the specified source field in the config file exists on the model, if not then use the source field as a string to prefix the SKU.