Skip to content

Commit

Permalink
trim down the number of steps
Browse files Browse the repository at this point in the history
  • Loading branch information
rgbkrk committed Jan 8, 2018
1 parent 42c8d85 commit 18c745f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 14 deletions.
6 changes: 1 addition & 5 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,9 @@ In order to build a signed copy with working auto-update, you will need to join

## Release Process

1. Run `npm run publish` to publish all the inner packages.

1. Run `npm run publish:commuter` (assuming the above worked)

1. Make sure the release is working by running `npm run dist` and testing the built app inside the `./applications/desktop/dist/` folder. You can build for all platforms using `npm run dist:all`.

1. Run `npm run publish:desktop` on macOS, Windows and Linux or run `npm run publish:desktop:all` to build everything on a single machine. This will draft a new release on GitHub and will upload all necessary assets.
1. Run `npm publish` to publish everything, which also runs the verification steps. You will have to pick versions for everything.

1. From GitHub go to [nteract's releases](https://github.com/nteract/nteract/releases), verify everything works and edit the release notes. The name should follow our [naming guidelines](https://github.com/nteract/naming), namely that we use the last name of the next scientist in the list with an adjective in front.
Example:
Expand Down
7 changes: 5 additions & 2 deletions applications/desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@
"build:watch": "npm run build -- --watch",
"pack": "npm run clean && webpack --config webpack.prod.js && electron-builder --dir",
"dist": "npm run clean && webpack --config webpack.prod.js && electron-builder",
"publish": "npm run clean && webpack --config webpack.prod.js && electron-builder -p always",
"// publish:one will only build for the current platform": "echo its for triaging broken releases",
"publish:one": "npm run clean && webpack --config webpack.prod.js && electron-builder -p always",
"publish": "npm run publish:one -- -mlw",
"dist:all": "npm run dist -- -mlw",
"publish:all": "npm run publish -- -mlw"
"// publish:all is basically deprecated": "echo yeah",
"publish:all": "npm run publish"
},
"build": {
"appId": "io.nteract.nteract",
Expand Down
2 changes: 1 addition & 1 deletion applications/jupyter-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
"prebuild:python": "rimraf dist",
"publish": "echo 'not really publishing'"
},
"repository": "https://github.com/nteract/nteract/tree/master/applications/jupyter-extension",
"publishConfig": {
"access": "public",
"dry-run": true
},
"private": true,
"repository": "https://github.com/nteract/nteract/tree/master/applications/jupyter-extension",
"author": "Kyle Kelley <[email protected]>",
"license": "BSD-3-Clause",
"devDependencies": {
Expand Down
8 changes: 2 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,11 @@
"precommit": "lint-staged",
"verifyBeforePublish": "lerna run prepublishOnly && lerna run prepare",
"prepublishOnly": "npm run verifyBeforePublish",
"publish": "lerna run publish --ignore nteract --ignore @nteract/commuter-frontend --ignore @nteract/commuter",
"prepublish:commuter": "npm run build:packages",
"publish:commuter": "lerna run publish --scope @nteract/commuter-frontend --scope @nteract/commuter",
"publish": "lerna run publish",
"prettify": "prettier --write '**/*.{js,json}' '!**/{lib,.git,.next,package.json,flow-typed}/**'",
"pack": "lerna run pack --scope nteract --stream",
"dist": "lerna run dist --scope nteract --stream",
"dist:all": "lerna run dist:all --scope nteract --stream",
"publish:desktop": "lerna run publish --scope nteract --stream",
"publish:desktop:all": "lerna run publish:all --scope nteract --stream"
"dist:all": "lerna run dist:all --scope nteract --stream"
},
"jest": {
"setupFiles": [
Expand Down

0 comments on commit 18c745f

Please sign in to comment.