sh: Avoid out-of-bounds access in setoptionbyindex() for 'set -o nolog'.

Reported by: hrs
biochemie · Mar 9, 2016 · e1e2ce9 · e1e2ce9
1 parent efc97b3
commit e1e2ce9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/bin/sh/options.c b/bin/sh/options.c
@@ -285,7 +285,7 @@ minus_o(char *name, int val)
 static void
 setoptionbyindex(int idx, int val)
 {
-	if (optletter[idx] == 'p' && !val && privileged) {
+	if (&optval[idx] == &privileged && !val && privileged) {
 		if (setgid(getgid()) == -1)
 			error("setgid");
 		if (setuid(getuid()) == -1)
@@ -294,9 +294,9 @@ setoptionbyindex(int idx, int val)
 	optval[idx] = val;
 	if (val) {
 		/* #%$ hack for ksh semantics */
-		if (optletter[idx] == 'V')
+		if (&optval[idx] == &Vflag)
 			Eflag = 0;
-		else if (optletter[idx] == 'E')
+		else if (&optval[idx] == &Eflag)
 			Vflag = 0;
 	}
 }