Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: domains docs and better linter docs #1820

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Conversation

ematipico
Copy link
Member

Summary

Closes #1758

Also, I took the opportunity to refactor the linter docs. I made it more linear, hoping to follow a more logical flow without jumping from one piece of information to another that might not be related. Let me know what you think

@ematipico ematipico requested review from a team March 9, 2025 14:53
Copy link

netlify bot commented Mar 9, 2025

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 95b1180
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/67cf50c6d117a000087f1af4
😎 Deploy Preview https://deploy-preview-1820--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

{
"linter": {
"domains": {
"test": "on"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this feeling it might be nicer if "test" were called "testing" instead 🤔

Copy link
Member Author

@ematipico ematipico Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings, we're still in time to change it:)

ematipico and others added 2 commits March 10, 2025 20:50
Co-authored-by: Arend van Beelen jr. <[email protected]>
Co-authored-by: Arend van Beelen jr. <[email protected]>
@ematipico ematipico merged commit 6c00549 into next Mar 10, 2025
3 checks passed
@ematipico ematipico deleted the feat/document-domains branch March 10, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants