Update bip-0345.mediawiki #1742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grammatical errors made to make reading easily digestible.
jonatack
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Closing, as this pull does not provide sufficient value to be worth valuable and scarce review time, is partially incorrect, and adds unneeded noise for subscribers to this repository and time requests for maintainers of this repository.
Rather than opening pull requests like this, may I suggest focusing efforts on:
- Updating already open PRs like Update BIP-352 status to Final #1737 in response to review feedback
- Opening PRs that provide more value
- Reviewing PRs by other contributors, which can be the best way to learn, improve, and add value. Please see this article for more information: https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
| @@ -81,7 +81,7 @@ Institutional custodians of Bitcoin may use vaults in similar fashion. | |||
|
|
|||
| This proposal provides a mitigation to the | |||
| [https://web.archive.org/web/20230210123933/https://xkcd.com/538/ "$5 wrench attack."] By | |||
| setting the spend delay to, say, a week, and using as the recovery path a | |||
| setting the spend delay to, say, a week, and using as the recovery path, a | |||
There was a problem hiding this comment.
This change doesn't appear to be grammatically correct.
|
sincerest appreciation @jonatack for sharing your article. I have gone through it, and I must say, it's really eye opening. Would avoid nits from now on, and keep review more PRs than opening. God bless you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammatical errors made to make reading easily digestible.