[PM-16431] Bugfix - Handle expiry field placeholder values with uppercased values #12559
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprusik
commented
Dec 23, 2024
| @@ -1514,7 +1514,7 @@ export default class AutofillService implements AutofillServiceInterface { | |||
| ); | |||
|
|
|||
| return CreditCardAutoFillConstants.CardAttributesExtended.find((attributeName) => { | |||
| const fieldAttributeValue = field[attributeName]; | |||
| const fieldAttributeValue = field[attributeName]?.toLocaleLowerCase(); | |||
There was a problem hiding this comment.
Enables us to maintain a list of lowercased patterns only
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12559 +/- ##
=======================================
Coverage 33.78% 33.79%
=======================================
Files 2912 2912
Lines 90693 90693
Branches 17151 17152 +1
=======================================
+ Hits 30641 30648 +7
+ Misses 57666 57659 -7
Partials 2386 2386 ☔ View full report in Codecov by Sentry. |
|
New Issues
|
differsthecat
approved these changes
Dec 23, 2024
jprusik
added
needs-qa
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16431
📔 Objective
Fix an issue autofilling card expiry date values when the field placeholders are uppercase
Note: this change/feature is behind the
enable-new-card-combined-expiry-autofillfeature-flag🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes